catching more bad params

tristanwietsma · Dec 1, 2014 · 034fc2f · 034fc2f
1 parent 0b40af9
commit 034fc2f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/key_test.go b/key_test.go
@@ -228,6 +228,22 @@ func TestParseBadUri(t *testing.T) {
 	if err := k.FromURI(uri); err == nil {
 		t.Errorf("Parse URI should have failed: %v", k)
 	}
+
+	uri = "otpauth://totp/label?secret=MFRGGZDFMZTWQ2LK&issuer=theIssuer&algo=SHA1&digits=X"
+	if err := k.FromURI(uri); err == nil {
+		t.Errorf("Parse URI should have failed: %v", k)
+	}
+
+	//uri = "otpauth://totp/label?secret=MFRGGZDFMZTWQ2LK&issuer=theIssuer&algo=SHA1&period=X"
+	//if err := k.FromURI(uri); err == nil {
+	//	t.Errorf("Parse URI should have failed: %v", k)
+	//}
+
+	uri = "otpauth://hotp/label?secret=MFRGGZDFMZTWQ2LK&issuer=theIssuer&algo=SHA1&counter=X"
+	if err := k.FromURI(uri); err == nil {
+		t.Errorf("Parse URI should have failed: %v", k)
+	}
+
 }
 
 func TestParseAlgo(t *testing.T) {

diff --git a/uri.go b/uri.go
@@ -57,7 +57,7 @@ func (k *Key) FromURI(uri string) error {
 	if u.Path == "" {
 		return errors.New("missing label")
 	}
-	(*k).Label = u.Path[1 : len(u.Path)-1]
+	(*k).Label = u.Path[1:len(u.Path)]
 
 	params := u.Query()
 	(*k).Secret = params.Get("secret")