Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency, optimized dist size #24

Merged
merged 2 commits into from Jul 26, 2018

Conversation

Solant
Copy link
Contributor

@Solant Solant commented Jul 6, 2018

#23

@Solant Solant changed the title Removed dependency, dist size decreased Removed dependency, optimized dist size Jul 6, 2018
Copy link

@austinpray austinpray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@@ -16,10 +16,9 @@
}
],
"devDependencies": {
"browserify": "^12.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for babel instead of browserify

@@ -0,0 +1,4 @@
{
"plugins": ["transform-object-assign", "transform-es2015-modules-umd"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -41,7 +39,7 @@ module.exports = function(el, onOver, onOut) {

// Public methods
h.options = function(opt) {
options = extend({}, options, opt);
options = Object.assign({}, options, opt);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tristen
Copy link
Owner

tristen commented Jul 26, 2018

Thanks for your patience. Changes look good. I'll get a release out shortly 👍.

@tristen tristen merged commit f4020cd into tristen:gh-pages Jul 26, 2018
@tristen tristen mentioned this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants