Uglify the individual sort files #129
Merged
+49
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reasoning makes sense to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try this library out and was confused by the fact that there's a production (i.e. minified) file for the main code, but not for files in
sortsI wanted to add along with it. This PR includes them in what is built by Grunt.Since this is now a tree of many files,
tablesort.min.jsgoes indist(which is laid out likesrc) instead of the top level. The only thing I see that referencestablesort.min.jsdirectly is the demo page, so that path has been updated.I'm not sure if you'd rather drop Grunt altogether (#122 ... obviously this now leans on Grunt for a bit more portable functionality, making that harder) or if the answer for someone for my case is "know how to construct your own build pipeline that gloms the minified scripts together" (I was able to do that manually, but I barely know what I'm doing here), but it seems like it'd be simpler for new users to be able to just copy a couple production-ready files.