Fix the build by fixing the (most recent) tests #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristen
reviewed
Jun 2, 2020
tristen
approved these changes
Jun 2, 2020
|
@tristen, shall I publish (If you want me to do it: do you simply bump the version, create the tag, and |
|
👋 Apologies for the late reply. Yeah, those steps are right. It's easy for me to do: https://www.npmjs.com/package/tablesort/v/5.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #181 broke the build four months ago.
It's not because
phantomjs[-prebuilt]is long dead (as @tristen suspected back then), but rather a missingt.end()at the end of that new “sorts with column keys” section of tests. (What I don't understand is how it could be that “tests pass[ed] locally” 🤷♂️)This fixes that.
I suggest we publish
5.2.1after merging this./cc @harimohanraj89