Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ability to sort via a custom attribute #198

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Adds ability to sort via a custom attribute #198

merged 2 commits into from
Oct 30, 2021

Conversation

jmlee2k
Copy link
Contributor

@jmlee2k jmlee2k commented Jul 6, 2020

This adds the ability to sort via a custom attribute (other than 'data-sort').

@moseslecce
Copy link

Hi, I am wondering if this will be accepted and released soon? It's been here for a while now. @tripu @tristen

@tripu
Copy link
Collaborator

tripu commented Oct 28, 2021

Hi. I'm not devoting much time to this project now, and I wouldn't be a good reviewer.

pinging @tristen or @harimohanraj89 …

tristen
tristen approved these changes Oct 30, 2021
View reviewed changes
Copy link
Owner

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for the contribution and apologies on the long delay

@tristen tristen merged commit 1a1bcda into tristen:gh-pages Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristen tristen tristen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmlee2k @moseslecce @tripu @tristen