Extendable tablesort

[xPaw]

This is for #74.

There's one problem with this approach though, because dotsep/filesize sorts get loaded later, they are not considered for sorting because number sort catches them first. There should be some kind of priority or something, I'm not entirely sure.

I've also added names for each sorting method, so it could also be used to fix #53.

[xPaw]

Hmm, tests passed for that, however I am sure filesize/dotsep sorting is wrong. These tests should be extended to cover more cases.

[tristen]

Awesome @xPaw! Before we get this in:

• Should we also move dates and currency out as well?
• Priority is totally going to be an issue ... I too can't think of a cleaner way than setting a priority index and it would be a very good idea not to set this index in the extend functions themselves. I wonder if:
  • We move every pattern/sort into separate files (core would have none) and priority is set by the order it's included in the HTML?
  • Priority is set as an option by users implementation? like sortorder: ['dotsep', 'number'] not huge on this idea.

This is a breaking change & should be tagged v3.0.0. I can jump on documentation and writing better coverage for our tests.

[xPaw]

Yeah I guess the other two sorts can be moved out as well, and that would kinda fix the priority issue (you would prioritize by including the files in order you need). I also thought about allowing to specify which sort method to use per column (via data-sort-method or something similar).

[tristen]

I also thought about allowing to specify which sort method to use per column (via data-sort-method or something similar).

This is a great idea & addresses #53 nicely. That would probably be a good change in addition to splitting all sorts out of core.

[xPaw]

I've added that, needs testing.

[xPaw]

@tristen Do you know if these lines are still needed, because I think they are not.

in getInnerText:

            if (typeof el === 'string' || typeof el === 'undefined') {
                return el;
            }

And as far as I know, textContent doesn't return HTML comments.

                // Exclude cell values where commented out HTML exists
                if (item.substr(0, 4) !== '<!--' && item.length !== 0) {
                    items.push(item);
                }

[tristen]

Yep! looks like those typeof checks can go now.

textContent should return HTML comments no? http://mistakes.io/#1be232a56d8a684ab428

[xPaw]

That's because you assigned it as a string: http://jsfiddle.net/thxefs90/

[tristen]

Oh derp: http://mistakes.io/#fc11895cd90f7ae05bfa Welp looks like that can go too!

[tristen]

Awesome work! I'll add words and tests a little later today.

[xPaw]

I squashed my changes into one commit.