Create new GRPC channel to work around max connection concurrency #55
Conversation
src/c++/library/grpc_client.cc
Outdated
| // clients to different channels relieve the pressure of reaching | ||
| // max connection concurrency | ||
| // https://docs.microsoft.com/en-us/aspnet/core/grpc/performance?view=aspnetcore-6.0#connection-concurrency | ||
| size_t max_share_count = 6; |
There was a problem hiding this comment.
const?
Does this need to be a parameter?
Is there an equivalent issue in the python library?
There was a problem hiding this comment.
This is a better location to link.. https://grpc.io/docs/guides/performance/
See the fourth point. They provide a side note saying:
Side note: The gRPC team has plans to add a feature to fix these performance issues (see grpc/grpc#21386 for more info), so any solution involving creating multiple channels is a temporary workaround that should eventually not be needed.
There was a problem hiding this comment.
For Python, we don't attempt channel reuse ourselves, we initialize new grpc channel object for new client. But we also don't do anything to prevent channel reuse within GRPC, assuming Python GRPC has similar behavior as in C++.
… (#57) * Create new GRPC channel to work around max connection concurrency * Modify channel assignment to prefer share * Address comment
No description provided.