Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new GRPC channel to work around max connection concurrency #55

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

GuanLuo
Copy link
Contributor

@GuanLuo GuanLuo commented Jan 13, 2022

No description provided.

// clients to different channels relieve the pressure of reaching
// max connection concurrency
// https://docs.microsoft.com/en-us/aspnet/core/grpc/performance?view=aspnetcore-6.0#connection-concurrency
size_t max_share_count = 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?
Does this need to be a parameter?
Is there an equivalent issue in the python library?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better location to link.. https://grpc.io/docs/guides/performance/
See the fourth point. They provide a side note saying:

Side note: The gRPC team has plans to add a feature to fix these performance issues (see grpc/grpc#21386 for more info), so any solution involving creating multiple channels is a temporary workaround that should eventually not be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Python, we don't attempt channel reuse ourselves, we initialize new grpc channel object for new client. But we also don't do anything to prevent channel reuse within GRPC, assuming Python GRPC has similar behavior as in C++.

@GuanLuo GuanLuo merged commit 396ad39 into main Jan 14, 2022
deadeyegoodwin pushed a commit that referenced this pull request Jan 15, 2022
… (#57)

* Create new GRPC channel to work around max connection concurrency

* Modify channel assignment to prefer share

* Address comment
@GuanLuo GuanLuo deleted the gluo-grpc branch March 15, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants