Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request parameters to Python models #213

Merged
merged 2 commits into from Mar 15, 2023
Merged

Add request parameters to Python models #213

merged 2 commits into from Mar 15, 2023

Conversation

Tabrizian
Copy link
Member

No description provided.

tanmayv25
tanmayv25 previously approved these changes Mar 13, 2023
View reviewed changes
krishung5
krishung5 previously approved these changes Mar 13, 2023
View reviewed changes
GuanLuo
GuanLuo reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@GuanLuo GuanLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Python model read the parameters as a JSON string?

@Tabrizian
Copy link
Member Author

@GuanLuo yes, that's correct.

@Tabrizian Tabrizian dismissed stale reviews from krishung5 and tanmayv25 via 502c5cd March 15, 2023 19:33
@Tabrizian Tabrizian requested a review from GuanLuo March 15, 2023 19:34
@Tabrizian Tabrizian merged commit 7f5f32e into main Mar 15, 2023
@Tabrizian Tabrizian deleted the imant-parameters branch March 15, 2023 19:51
@Tabrizian Tabrizian restored the imant-parameters branch March 15, 2023 19:51
@Tabrizian Tabrizian deleted the imant-parameters branch March 15, 2023 20:14
@Tabrizian Tabrizian mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@krishung5 krishung5 krishung5 left review comments

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Tabrizian @tanmayv25 @GuanLuo @krishung5