New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests to make Python backend work with L0_infer #1991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of follow-on changes we can make that I commented on, but I'm going to merge it as is for now.
@@ -232,6 +232,17 @@ def _infer_exact_helper(tester, | |||
output1_raw=output1_raw, | |||
swap=swap) | |||
|
|||
if prefix == "": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should still use tu.validate_for_python_model here. It can just always return true.
@@ -0,0 +1,76 @@ | |||
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It strange to have both add_sub and sub_add when they are nearly identical. There is a better way to do this that we can discuss.
No description provided.