-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-throw certain specific OOM errors as 507 for SageMaker MME + repo path enhancement #4392
Conversation
src/sagemaker_server.cc
Outdated
return; | ||
} else { | ||
/* Return a 400*/ | ||
evhtp_send_reply(req, EVHTP_RES_BADREQ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this should be done outside the for loop, so it checks if any messages are matched before returning 400 early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nskool let me know when it is ready for a CI run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed - request you to run the CI
/opt/ml/models/<hash>/model
as well as/opt/ml/models/<hash>/model/<model_subdir>
. The second one is useful if the customer is re-using a model after trying it in SME mode.