Re-throw certain specific OOM errors as 507 for SageMaker MME + repo path enhancement #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
reviewed
May 18, 2022
nskool
changed the title
GuanLuo
reviewed
May 19, 2022
src/sagemaker_server.cc
Outdated
| return; | ||
| } else { | ||
| /* Return a 400*/ | ||
| evhtp_send_reply(req, EVHTP_RES_BADREQ); |
There was a problem hiding this comment.
Actually this should be done outside the for loop, so it checks if any messages are matched before returning 400 early
There was a problem hiding this comment.
@nskool let me know when it is ready for a CI run
There was a problem hiding this comment.
thanks, fixed - request you to run the CI
GuanLuo
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/opt/ml/models/<hash>/modelas well as/opt/ml/models/<hash>/model/<model_subdir>. The second one is useful if the customer is re-using a model after trying it in SME mode.