Register TensorFlow Plugins at Runtime #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
requested review from
jbkyang-nvi
and removed request for
Tabrizian
tanmayv25
requested changes
Oct 5, 2022
dyastremsky
force-pushed
the
dyas-runtime-lib
branch
from
5e267b1
to
c3359ac
Compare
tanmayv25
previously approved these changes
Oct 6, 2022
jbkyang-nvi
reviewed
Oct 6, 2022
qa/L0_custom_ops/test.sh
Outdated
| @@ -60,6 +60,7 @@ RET=0 | |||
| LD_LIBRARY_PATH=/opt/tritonserver/backends/tensorflow2:$LD_LIBRARY_PATH | |||
|
|
|||
| # Tensorflow | |||
| ## LD_PRELOAD | |||
There was a problem hiding this comment.
I added it to distinguish this sub-test (LD_PRELOAD) vs the one below (Runtime loading via config). Updated the wording to "Load operations via LD_PRELOAD" and "Load operations via model config" to be clearer. Let me know if you'd prefer different wording.
There was a problem hiding this comment.
If you'd like any other changes, please let me know.
dyastremsky
force-pushed
the
dyas-runtime-lib
branch
from
10ebef6
to
80579a4
Compare
dyastremsky
force-pushed
the
dyas-runtime-lib
branch
from
80579a4
to
b67fff7
Compare
dyastremsky
force-pushed
the
dyas-runtime-lib
branch
from
b67fff7
to
ad4aa85
Compare
tanmayv25
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorFlow: triton-inference-server/tensorflow_backend#79