Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable TF-TRT tests #7399

Merged
merged 5 commits into from
Jul 11, 2024
Merged

ci: Enable TF-TRT tests #7399

merged 5 commits into from
Jul 11, 2024

Conversation

pskiran1
Copy link
Contributor

@pskiran1 pskiran1 commented Jul 1, 2024

What does the PR do?

This PR re-enables the L0_tftrt_optimization and L0_warmup TF-TRT tests that have been disabled since 24.05.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 16218566

Caveats:

Background

In the 24.05 release, implicit batch support was removed as part of the TRT v10 upgrade. As a result, the TF backend was unable to build TF-TRT engines for implicit batch TF models because it was using implicit batching by default. In the upcoming TF release, the TF backend will use dynamic batching by default, enabling it to successfully build TF-TRT models.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 requested review from tanmayv25 and mc-nv July 1, 2024 17:11
@pskiran1 pskiran1 marked this pull request as ready for review July 1, 2024 17:12
tanmayv25
tanmayv25 previously approved these changes Jul 1, 2024
@tanmayv25
Copy link
Contributor

Don't merge just yet. Once the r24.07 branch is ready, then merge these changes into that branch.

@pskiran1 pskiran1 mentioned this pull request Jul 8, 2024
20 tasks
@krishung5
Copy link
Contributor

krishung5 commented Jul 8, 2024

@pskiran1 Could you change the target branch to r24.07?
NVM, I saw that the release branch is up to date with main, so went ahead and changed it.

@krishung5 krishung5 changed the base branch from main to r24.07 July 8, 2024 21:24
@krishung5 krishung5 dismissed tanmayv25’s stale review July 8, 2024 21:24

The base branch was changed.

@mc-nv
Copy link
Contributor

mc-nv commented Jul 10, 2024

can we change target branch to main I don't see any value in this change for release branch.

@krishung5
Copy link
Contributor

@mc-nv I have no strong objections to change it to target main since it's only change in comments in the tests, but I would still slightly prefer to merge it into the release branch first, then merge into main after 24.07 gets released. The reason being that, the implicit batch will only be supported from 24.07 upstream while as of now the main hasn't been advanced to 24.07 DLFW yet and hence doesn't have the support for implicit batch.

@mc-nv mc-nv merged commit fd9f205 into r24.07 Jul 11, 2024
3 checks passed
@mc-nv mc-nv deleted the spolisetty_tf_trt_tests branch July 11, 2024 16:07
pvijayakrish pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants