Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP] Fixed dependencies #1389

Merged
merged 4 commits into from
Mar 22, 2023
Merged

[SETUP] Fixed dependencies #1389

merged 4 commits into from
Mar 22, 2023

Conversation

ptillet
Copy link
Collaborator

@ptillet ptillet commented Mar 22, 2023

No description provided.

@ptillet ptillet merged commit 7c7b769 into main Mar 22, 2023
@ptillet ptillet deleted the phil/fix-deps branch March 22, 2023 23:15
"tests": [
"autopep8",
"flake8",
"isort",
"numpy",
"pytest",
"scipy>=1.7.1",
"torch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that installing just triton on a fresh environment without torch won't work except if we pass the test argument as well
https://github.com/openai/triton/blob/3239c93a934d3e8d431da00d9076e7f9b6d7f69d/python/triton/__init__.py#L9
Probably worth at least a note in the documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm working on fixing that now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants