Don't hold a file lock #1569
Merged
Don't hold a file lock #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptillet
approved these changes
Apr 24, 2023
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
We have had complaints/issues randomly where a zombie python process is holding this lock. We don't need it since renames are atomic on posix. So refactor this to make temp files unique and then use replace (https://docs.python.org/3/library/os.html#os.replace )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had complaints/issues randomly where a zombie python process is holding this lock. We don't need it since renames are atomic on posix. So refactor this to make temp files unique and then use replace (https://docs.python.org/3/library/os.html#os.replace )