Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX/UI Header_TooltipDarkThemeIcon: not enough contrast, login button and tooltip overlap each other and merge #697

Closed
EkaterinaSokolova-V opened this issue Apr 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working design p1

Comments

@EkaterinaSokolova-V
Copy link
Collaborator

EkaterinaSokolova-V commented Apr 19, 2024

Steps:

  1. Open any page, for example: https://mastersway-dev.netlify.app/ways
  2. Light theme selected.
  3. Hover over the theme icon.

Expected result:
"Switch to dark theme" tooltip appears next to Theme icon. All other header elements are visible.

Actual result:
Login button and tooltip overlap each other and merge. Both has the same color, there is no any contrast border of the tooltip.

Image

Please compare with a similar situation but for a dark theme:

Image

Enviroment:
Windows 11, Chrome Version 123.0.6312.123 (Official Build) (64-bit)

@EkaterinaSokolova-V EkaterinaSokolova-V added the bug Something isn't working label Apr 21, 2024
@EkaterinaSokolova-V
Copy link
Collaborator Author

@vikpak89 vikpak89 added design bug Something isn't working and removed bug Something isn't working labels Apr 25, 2024
@vikpak89 vikpak89 self-assigned this Apr 25, 2024
@Ekaterina1994
Copy link
Collaborator

Need to fix variable = text is not border )

Image

@Ekaterina1994
Copy link
Collaborator

Do we need updated styles for ttoltip according design ( on image)? Right now tooltips in demo is nor equal to the figma imiage. Or it will be other task?

@tritonJS826 tritonJS826 added the p1 label May 12, 2024
AKiroi added a commit that referenced this issue May 21, 2024
@EkaterinaSokolova-V
Copy link
Collaborator Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design p1
Projects
Development

No branches or pull requests

5 participants