Skip to content
This repository has been archived by the owner on Dec 27, 2021. It is now read-only.

Added pbzip2 parallel decompression support #16

Merged
merged 6 commits into from
May 26, 2018

Conversation

0rinsb3lt
Copy link
Contributor

Fixed pull request to just include pbzip2

@0rinsb3lt 0rinsb3lt mentioned this pull request May 17, 2018
@tritonas00
Copy link
Owner

please edit:

$BRmcore to "$BRmcore"
${BRreadopts} to "$BRreadopts"

and its ok.

of course we need to add extra check for pbizp2 package existence and update the help page and gui

i will apply the PR and do the extra work when i have my laptop

@0rinsb3lt
Copy link
Contributor Author

0rinsb3lt commented May 17, 2018

I used ${BRreadopts} because it wouldn't work with just the quotes or with quotes and brackets due to the multiple hyphens. I have tested both conditions.

will update $BRmcore to "$BRmcore"

@tritonas00
Copy link
Owner

tritonas00 commented May 17, 2018

lines 500-501 are wrong and update please BRreadopts also

@0rinsb3lt
Copy link
Contributor Author

I've tested "$BRreadopts" but it doesn't work. It'll spit out errors.
Probably be better to convert it to an array like BR_MAIN_OPTS
Due to the way bash handles passing variables to commands as parameters with spaces.

@tritonas00
Copy link
Owner

Ok then

Converted BRreadopts to array
updated BR_MAIN_OPTS to match rest of script
@tritonas00
Copy link
Owner

tritonas00 commented May 17, 2018

please quote BRreadopts array in read_archive and convert BR_MAIN_OPTS to array also here https://github.com/tritonas00/system-tar-and-restore/blob/master/star.sh#L909 and test

@tritonas00
Copy link
Owner

@tritonas00
Copy link
Owner

looks good!

@tritonas00 tritonas00 merged commit 1192b63 into tritonas00:master May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants