Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make test" re-clones dependencies every time #64

Closed
tgross opened this issue Jan 5, 2016 · 2 comments
Closed

"make test" re-clones dependencies every time #64

tgross opened this issue Jan 5, 2016 · 2 comments
Assignees
@tgross
Labels
bug fixed

Comments

@tgross
Copy link
Contributor

tgross commented Jan 5, 2016

The way that the DOCKERMAKE is used in #57 is causing all dependencies to be re-cloned into the container for every test run. I'm going to look into this to reduce test iteration speed.
@tgross tgross added the bug label Jan 5, 2016
@tgross tgross self-assigned this Jan 5, 2016
@tgross
Copy link
Contributor Author

tgross commented Jan 5, 2016

I see where the problem is: the deps target in Makefile.docker is PHONY when it should be leaving behind the dependencies directory on disk. If we mount a .godeps directory on the builder container then we can drop the dependencies in the appropriate place (might need to add GOPATH manipulation into the builder container to do so).

@tgross tgross mentioned this issue Jan 5, 2016
Merged
@tgross tgross added the open PR label Jan 5, 2016
@tgross
Copy link
Contributor Author

tgross commented Jan 5, 2016

Merged in #65

@tgross tgross closed this as completed Jan 5, 2016
@justenwalker justenwalker mentioned this issue Jan 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgross tgross

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgross