Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twin import event #137

Open
b0ykoe opened this issue Feb 7, 2021 · 2 comments
Open

twin import event #137

b0ykoe opened this issue Feb 7, 2021 · 2 comments
Assignees
Labels
type:feature A new functionality

Comments

@b0ykoe
Copy link

b0ykoe commented Feb 7, 2021

Is your feature request related to a problem? Please describe.
Importing the TWIN command (/twin hash) does not seem to refresh some parts of the game. We're covering that part with the PlayerLanguageChangeEvent but we're missing a event for the TWIN command.

Describe the solution you'd like
Implementing a TwinLanguageUpdateEvent would be a good idea for that.

Describe alternatives you've considered
Well we could start a scheduler and check if somethings got changed but that would be heavy on ressources.

Additional context

@b0ykoe b0ykoe added the type:feature A new functionality label Feb 7, 2021
@diogotcorreia
Copy link
Member

As an alternative for now:

On Spigot, use can use the PlayerCommandPreprocessEvent to listen for the /twin command, and if it has more than one argument (that is, it is downloading something), start a task with a delay of ~1-2s (to allow it to download and update everything) and then do whatever you want to do 😄

However, this would only work if you're not using BungeeCord since I don't think there is a similar event there 😢

@b0ykoe
Copy link
Author

b0ykoe commented Feb 9, 2021

Yeah true, its not the most important part right now but if you find the time I would appriciate it if you add the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature A new functionality
Projects
None yet
Development

No branches or pull requests

2 participants