Prevent refresh race conditions #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 7, 2016 19:10
| mTokenObservable = null; | ||
| }) | ||
| .toObservable() | ||
| .cache(); |
There was a problem hiding this comment.
cache here would mean that every time we subscribe every element will be replayed right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This is pretty similar to the bug found in the iOS version of Heimdallr
Description
When calling
getValidAccessToken()multiple times it might query any amount of refresh calls. This might confuse/flood the server and the app behaving not as expected.Solution
On
grantNewAccessTokenwhich is called fromgetValidAccessTokenwe check if there already is a request to grab the access token. If so we simply subscribe to it. Only if there is none we create a new one.