Removing Argo #91
Merged
Removing Argo #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has anyone had a chance to take a look at this? 😁 |
| @@ -155,10 +155,9 @@ public let HeimdallrErrorNotAuthorized = 2 | |||
| completion(.Failure(error)) | |||
| } | |||
| } else { | |||
| switch OAuthError.decode(data!) { | |||
| case let .Success(error): | |||
| if let error = OAuthError.decode(data: data!) { | |||
There was a problem hiding this comment.
Would you mind manually unwrapping data, potentially failing by not satisfying a condition or using fatalError with an appropriate error message if data is nil?
There was a problem hiding this comment.
@felixjendrusch Done in 4ab6083
|
I would give it a go. I do not think that the dependency update should do any harm. @felixjendrusch Green from your side? And once more: Thank you @marcelofabri and a big 👍 for contributing. |
|
@hffmnn yo. Thanks @marcelofabri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #90
I wasn't able to figure out a way to make Carthage just remove Argo, so I had to run
carthage update ..., which updated Nimble, Result and ReactiveCocoa. I hope it's not a problem.