Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional http health endpoint #88

Closed
arnecls opened this issue Apr 3, 2017 · 1 comment
Closed

Add an optional http health endpoint #88

arnecls opened this issue Apr 3, 2017 · 1 comment
Assignees
Projects
Milestone

Comments

@arnecls
Copy link
Contributor

arnecls commented Apr 3, 2017

Currently we (and probably others, too) use the metrics provided by gollum to do health checking.
A better way would be to allow plugins to return a health state that can be queried by a given http endpoint.

  • Add a new commandline flag to gollum to open up an http endpoint like gollum --health=:80
  • A general health check should be added to /health (maybe based on error/warning messages per second)
  • Health checks should be added to /health/plugin_id
  • Plugins can implement a HealthCheck interface GetHealth() (Status, string) where status can be of ok, warning or critical
  • We should discuss wether to use different http status codes and if yes, which ones depending on the returned status
@arnecls arnecls added this to the v0.5.0 milestone Apr 3, 2017
@arnecls arnecls added this to Backlog in v0.5.0 Apr 3, 2017
@ppar ppar self-assigned this Apr 10, 2017
@arnecls arnecls moved this from Backlog to In progress in v0.5.0 Apr 24, 2017
arnecls added a commit that referenced this issue May 3, 2017
Health check endpoint, with sample implementation for prod.HTTPRequest (#88)
@ppar
Copy link
Contributor

ppar commented May 4, 2017

Fixed by PR #105 commit f1a0109

@ppar ppar closed this as completed May 4, 2017
@arnecls arnecls moved this from In progress to Done in v0.5.0 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants