Enhancement/rename streams to router #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 6, 2017 13:45
added 9 commits
April 7, 2017 09:57
msiebeneicher
changed the title
arnecls
requested changes
Apr 19, 2017
core/message.go
Outdated
| func (msg *Message) GetStream() Stream { | ||
| return StreamRegistry.GetStreamOrFallback(msg.streamID) | ||
| // GetRouter returns the stream object behind the current StreamID. | ||
| func (msg *Message) GetStream() Router { |
There was a problem hiding this comment.
Function should be renamed
core/message.go
Outdated
| } | ||
|
|
||
| // GetPreviousStream returns the stream object behind the previous StreamID. | ||
| func (msg *Message) GetPreviousStream() Stream { | ||
| return StreamRegistry.GetStreamOrFallback(msg.prevStreamID) | ||
| func (msg *Message) GetPreviousStream() Router { |
There was a problem hiding this comment.
Function should be renamed
core/simpleconsumer.go
Outdated
| @@ -218,7 +218,7 @@ func (cons *SimpleConsumer) Enqueue(data []byte) { | |||
| // EnqueueWithSequence works like Enqueue but allows to set a custom sequence | |||
| // number. The internal sequence number is not incremented by this function. | |||
| func (cons *SimpleConsumer) EnqueueWithSequence(data []byte, seq uint64) { | |||
| numStreams := len(cons.streams) | |||
| numStreams := len(cons.routers) | |||
There was a problem hiding this comment.
rename variable to numRouters
core/streamregistry.go
Outdated
| // AddAllWildcardProducersToAllStreams executes AddWildcardProducersToStream on | ||
| // all currently registered streams | ||
| // AddAllWildcardProducersToAllStreams executes AddWildcardProducersToRouter on | ||
| // all currently registered routers | ||
| func (registry *streamRegistry) AddAllWildcardProducersToAllStreams() { |
|
@arnecls : PR is updated |
arnecls
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #80
What this PR does:
gollum -l