Experimental synchronous deep rendering #40
Conversation
|
@abertelle You'll need to modify the bundlesize limit (within the |
Pull Request Test Coverage Report for Build 44
💛 - Coveralls |
| @@ -80,7 +81,7 @@ describe('component', function() { | |||
| data => { | |||
| component(Component, 'test', data); | |||
| }, | |||
| { text: 'Hello' }, | |||
| { text: 'Hello' } | |||
There was a problem hiding this comment.
Why are all trailing comma removed in this file?
There was a problem hiding this comment.
Most probably I had a different config for Prettier on the Melody workspace and I didn't see that.
Shall i change it back?
There was a problem hiding this comment.
I realized that we changed the comma rule to the es5 because of build process at some point mosty likely due to a CI change. It may not be his fault.
There was a problem hiding this comment.
I also want to suggest not doing prioritization according to this flag as well. @pago @krakenfuss ?
As suggested please revert the prettier changes.
|
We can merge this looks good @jamesb3ll @abertelle |
|
LGTM 😃 |
Adds option to activate synchronous rendering of components