Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Fields causing get_items crash #227

Closed
Mariadb-colebusby opened this issue Jul 29, 2022 · 3 comments
Closed

Timeline Fields causing get_items crash #227

Mariadb-colebusby opened this issue Jul 29, 2022 · 3 comments

Comments

@Mariadb-colebusby
Copy link

from_date = datetime.strptime(value['from'], DATE_FORMAT)

When a timeline field somehow gets an errant value without from, or to values (example below), the library fails to pull in items from get_items calls.

The following is an example from our board. In our efforts with monday.com support to attempt to get more information on how this can occur, they were unable to successfully replicate this issue in their API. FURTHER, these fields bypass the audit log/activity log and the support teams failed to update their API to track these changes.

{
  "id": "timeline",
  "value": "{\"changed_at\":\"2022-07-11T13:08:20.385Z\"}",
  "text": ""
}
@Mariadb-colebusby
Copy link
Author

I believe modifying the try/except in the given file or adding an additional to return a null field value would be the best solution to move forward.

@Mariadb-colebusby
Copy link
Author

@ManjotS 's PR would be satisfactory to our needs
Screen Shot 2022-07-29 at 11 33 09 AM
.

@Ashatz
Copy link
Contributor

Ashatz commented Jul 29, 2022

@Mariadb-colebusby I would concur with you on both regards. The monday.com api is truly a strange beast... The fix that was submitted is indeed satisfactory.

Thank you both for bringing this to my attention. I will get this merged.

@Ashatz Ashatz closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants