Update FTDictionaryClass.f90

[DavidAKopriva]

Move objectForKeyInList code into the ObjectForKey function to work around segfault issue with the gfortran 13.1.0 compiler. That routine is not called from anywhere else, so no other modifications are necessary.

[codecov]

Codecov Report

Merging #18 (0d9d8fc) into main (7c82d7a) will increase coverage by 0.32%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   67.94%   68.26%   +0.32%     
==========================================
  Files          28       28              
  Lines        2433     2433              
==========================================
+ Hits         1653     1661       +8     
+ Misses        780      772       -8     

Flag	Coverage Δ
unittests	68.26% <92.30%> (+0.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Testing/Tests/MutableArrayTests.f90	98.11% <80.00%> (+0.11%)	⬆️
Source/FTObjects/FTDictionaryClass.f90	59.39% <100.00%> (-0.90%)	⬇️

... and 2 files with indirect coverage changes

[sloede]

The test failure on macOS is likely due to our CI configuration, which is done in .github/workflows/ci.yml. Here we use macos-latest as the image for the test server, and gfortran-10 as the compiler executable:

FTObjectLibrary/.github/workflows/ci.yml

Lines 30 to 31 in 7c82d7a

	- os: macos-latest
	compiler: gfortran-10

When looking at the GitHub Action runner-images repo, specifically in the docs for macos-latest a.k.a. macOS-12, the oldest gfortran version listed is now gfortran-11. Thus to fix this, you probably only need to change line 31 above from gfortran-10 to gfortran-11.

As to why the Windows tests fail, I don't know. The test suite fails without an error message or anything, but there is no output whatsoever. Maybe you can temporarily amend the compiler flags in this PR to create a debug build (e.g., with -g2 -O0) and hopefully get more helpful error messages? The flags are set in the CMakeLists.txt file:

FTObjectLibrary/CMakeLists.txt

Line 7 in 7c82d7a

SET(FFLAGS "-cpp -O -std=f2008 -pedantic -Werror -fimplicit-none -Wall -Wextra -Wcharacter-truncation -Wimplicit-interface -Wimplicit-procedure -Wno-compare-reals -Wno-unused-dummy-argument -Wno-intrinsic-shadow -Wno-implicit-interface -Wno-implicit-procedure" CACHE STRING "Fortran compiler flags")

I hope this helps (a little)

[andrewwinters5000]

LGTM! This is ready to merge whenever you are ready @DavidAKopriva .