Increase coverage #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coverage for valueDictionary methods.
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
===========================================
+ Coverage 68.26% 94.55% +26.28%
===========================================
Files 28 31 +3
Lines 2433 2810 +377
===========================================
+ Hits 1661 2657 +996
+ Misses 772 153 -619
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Use routine missed in previous commit. fix bug in casting subroutine where the wrong pointer was nullified.
Add coverage for FTValue.
Add integer value coverage.
Add logical conversion tests. Change string return on logical to lower case.
andrewwinters5000
requested changes
May 29, 2023
Add additional tests for plain dictionaries. Use the NEW_LINE function to add newline character instead of the less portable char(13)
Add key-object pair tests
Add a test using isUnreferenced in the FTObject class for the subclass of FTValue. Add coverage for casting and class name for StringSets.
Add tests for casting and object type. Fix comment in the original class code..
Add more testing of exceptions
Add forgotten test of casting by function call.
Increase stack coverage plus some formatting.
Increase coverage of linked list class. Remove a superseded procedure that isn't used. Add testing for inserting an object.
Add coverage for MatrixData, and fix comments in FTSparseMatrixClass
* Update Comparisons.f90 Replace pure relative error test in the comparisons with an absolute + relative error test. The same tolerance is used for each. * Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Add absolute error as an optional argument to allow flexibility in setting both absolute and relative error tests. Reduces to a pure relative error test by default.
Fix capitalization
Add tests for multindexTable.
Add a getter for the output unit, test set and get, and execute finalize.
Add tests for additional procedures in Comparisons.f90
Add a couple of individual negative tests.
Add tests for FTData, including some updates to the class.
Fix compiler name in makefile.
Fix spelling
Adding coverage of assertions.
Delete unused variables.
Fix typo
Add finalization
andrewwinters5000
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Nice work @DavidAKopriva adding all the new tests! I know that this process can be very tiresome. Most of my suggestions are formatting related as everything else already looks good.
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Code formatting change.
…/FTObjectLibrary into IncreaseCoverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for valueDictionary methods.