Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wrapper function #12

Merged
merged 11 commits into from
Nov 5, 2021
Merged

Update the wrapper function #12

merged 11 commits into from
Nov 5, 2021

Conversation

andrewwinters5000
Copy link
Member

This PR adds a check for the mesh file format from the control file and appropriately sets the file extension of the generated mesh file. Also add a test of the ABAQUS formatted output using AbaqusReader.jl to ensure that the created mesh file is valid.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #12 (0819077) into main (0cd454b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           30        40   +10     
=========================================
+ Hits            30        40   +10     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HOHQMesh.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd454b...0819077. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 4, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 0819077 on add-abaqus into 0cd454b on main.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! I left a few comments with (minor) suggestions and/or questions.

examples/ABAQUS_IceCreamCone.control Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the last comment is resolved, this can be merged.

test/runtests.jl Outdated Show resolved Hide resolved
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloede sloede merged commit d2db00e into main Nov 5, 2021
@sloede sloede deleted the add-abaqus branch November 5, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants