Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crate-ci/typos from 1.14.12 to 1.15.5 #26

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2023

Bumps crate-ci/typos from 1.14.12 to 1.15.5.

Release notes

Sourced from crate-ci/typos's releases.

v1.15.5

[1.15.5] - 2023-06-22

Fixes

  • Don't correct typos.toml

v1.15.4

[1.15.4] - 2023-06-22

Fixes

  • Correctly merge default setting for a file type with a user's file type settings

v1.15.3

[1.15.3] - 2023-06-21

Fixes

  • User config overrides default glob definitions

v1.15.2

[1.15.2] - 2023-06-20

Fixes

  • Ensure atomic output is locked

v1.15.1

[1.15.1] - 2023-06-19

Fixes

  • Don't correct accreting

v1.15.0

[1.15.0] - 2023-06-08

Fixes

  • Major dictionary update
Changelog

Sourced from crate-ci/typos's changelog.

[1.15.5] - 2023-06-22

Fixes

  • Don't correct typos.toml

[1.15.4] - 2023-06-22

Fixes

  • Correctly merge default setting for a file type with a user's file type settings

[1.15.3] - 2023-06-21

Fixes

  • User config overrides default glob definitions

[1.15.2] - 2023-06-20

Fixes

  • Ensure atomic output is locked

[1.15.1] - 2023-06-19

Fixes

  • Don't correct accreting

[1.15.0] - 2023-06-08

Fixes

  • Major dictionary update
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.14.12 to 1.15.5.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.14.12...v1.15.5)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #26 (d96bf86) into main (a33de64) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          20       20           
  Lines        1838     1838           
=======================================
  Hits         1817     1817           
  Misses         21       21           
Flag Coverage Δ
unittests 98.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HOHQMesh.jl 100.00% <ø> (ø)
src/Misc/NotificationCenter.jl 100.00% <100.00%> (ø)

@ranocha
Copy link
Member

ranocha commented Jun 26, 2023

I fixed some typos in comments. The remaining typos it complains about are fnction in something like

addObserver(observer::Any, note::String, fnction::Any)

You can either add fnction to the list of accepted words or change it to something like f or so. What would you prefer, @DavidAKopriva and @andrewwinters5000?

@coveralls
Copy link

coveralls commented Jun 26, 2023

Coverage Status

Changes unknown
when pulling d96bf86 on dependabot/github_actions/crate-ci/typos-1.15.5
into ** on main**.

Change variable name from `fnction` to `f`
@andrewwinters5000
Copy link
Member

I fixed some typos in comments. The remaining typos it complains about are fnction in something like

addObserver(observer::Any, note::String, fnction::Any)

You can either add fnction to the list of accepted words or change it to something like f or so. What would you prefer, @DavidAKopriva and @andrewwinters5000?

I talked to David about this. I changed the variable name to f because that seemed the easiest route.

@andrewwinters5000 andrewwinters5000 merged commit eddb174 into main Jun 27, 2023
10 checks passed
@andrewwinters5000 andrewwinters5000 deleted the dependabot/github_actions/crate-ci/typos-1.15.5 branch June 27, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants