Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RectilinearGrid files #16

Merged
merged 24 commits into from
Feb 24, 2023
Merged

Support RectilinearGrid files #16

merged 24 commits into from
Feb 24, 2023

Conversation

boriskaus
Copy link
Contributor

This adds support for RectilinearGrid (*.vtr) files, and includes routines to retrieve 1D coordinate vectors.
It also includes get_data_reshaped which reshapes the structured data in the appropriate formatfor ImageData and RectilinearGrid.

sloede
sloede requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! Overall it looks to be in great shape already, I only left a few minor comments/suggestions.

Please also add your name to the author's list in the README.md.

README.md Outdated Show resolved Hide resolved
src/ReadVTK.jl Outdated Show resolved Hide resolved
src/ReadVTK.jl Outdated Show resolved Hide resolved
src/ReadVTK.jl Outdated Show resolved Hide resolved
src/ReadVTK.jl Outdated Show resolved Hide resolved
src/ReadVTK.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/rectilinear.jl Outdated Show resolved Hide resolved
test/rectilinear.jl Outdated Show resolved Hide resolved
boriskaus and others added 9 commits February 24, 2023 15:15
@boriskaus @sloede
Update README.md
972435c 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
67fe79d 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
ac18196 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
d50eb4a 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
d5b0f0d 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update test/runtests.jl
2ed7d38 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update test/runtests.jl
8b19d13 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update test/rectilinear.jl
e7af0bd 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus
added requested changes
0dbc409
@boriskaus
Copy link
Contributor Author

thanks a lot for the quick review! I've added the requested changes.

sloede
sloede reviewed Feb 24, 2023
View reviewed changes
src/ReadVTK.jl Outdated Show resolved Hide resolved
sloede
sloede reviewed Feb 24, 2023
View reviewed changes
src/ReadVTK.jl Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 24, 2023 •
edited
Loading

Coverage Status

Coverage: 93.846% (+0.7%) from 93.191% when pulling 9ed6fbf on boriskaus:bk-support-vtr into 082c072 on trixi-framework:main.

boriskaus and others added 10 commits February 24, 2023 15:46
@boriskaus
leftover debugging
1c5eac1
@boriskaus
Merge remote-tracking branch 'origin/bk-support-vtr' into bk-support-vtr
881784e
@boriskaus @sloede
Update src/ReadVTK.jl
e89d8c0 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
249bcaf 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
3bd3d55 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
d5b99ac 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
7bc6463 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
81f52f9 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus @sloede
Update src/ReadVTK.jl
d24a601 
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@boriskaus
typo
9ed6fbf
ranocha
ranocha approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@ranocha ranocha requested a review from sloede February 24, 2023 15:06
sloede
sloede approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for the contribution @boriskaus!

@sloede sloede merged commit 21ea09d into JuliaVTK:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

@ranocha ranocha ranocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boriskaus @coveralls @sloede @ranocha