Skip to content

Commit

Permalink
remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
huiyuxie committed May 3, 2024
1 parent 388917b commit 77e32d0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/equations/compressible_euler_1d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ Entropy conserving two-point flux by

# Compute the necessary mean values
rho_avg = 0.5f0 * (rho_ll + rho_rr)
rho_mean = ln_mean(rho_ll, rho_rr) # TODO: Modify ln_mean() from math.jl
beta_mean = ln_mean(beta_ll, beta_rr) # TODO: Modify ln_mean() from math.jl
rho_mean = ln_mean(rho_ll, rho_rr)
beta_mean = ln_mean(beta_ll, beta_rr)
beta_avg = 0.5f0 * (beta_ll + beta_rr)
v1_avg = 0.5f0 * (v1_ll + v1_rr)
p_mean = 0.5f0 * rho_avg / beta_avg
Expand Down Expand Up @@ -392,12 +392,12 @@ See also
rho_rr, v1_rr, p_rr = cons2prim(u_rr, equations)

# Compute the necessary mean values
rho_mean = ln_mean(rho_ll, rho_rr) # TODO: Modify ln_mean() from math.jl
rho_mean = ln_mean(rho_ll, rho_rr)
# Algebraically equivalent to `inv_ln_mean(rho_ll / p_ll, rho_rr / p_rr)`
# in exact arithmetic since
# log((ϱₗ/pₗ) / (ϱᵣ/pᵣ)) / (ϱₗ/pₗ - ϱᵣ/pᵣ)
# = pₗ pᵣ log((ϱₗ pᵣ) / (ϱᵣ pₗ)) / (ϱₗ pᵣ - ϱᵣ pₗ)
inv_rho_p_mean = p_ll * p_rr * inv_ln_mean(rho_ll * p_rr, rho_rr * p_ll) # TODO: Modify inv_ln_mean() from math.jl
inv_rho_p_mean = p_ll * p_rr * inv_ln_mean(rho_ll * p_rr, rho_rr * p_ll)
v1_avg = 0.5f0 * (v1_ll + v1_rr)
p_avg = 0.5f0 * (p_ll + p_rr)
velocity_square_avg = 0.5f0 * (v1_ll * v1_rr)
Expand Down

0 comments on commit 77e32d0

Please sign in to comment.