Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new feature xmin/xmax of SummationByPartsOperators.jl #1015

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Dec 13, 2021

I added (non-exported) interface functions xmin(D) and xmax(D) to SummationByPartsOperators.jl. This allows us to query the boundary of the domain specified when constructing the SBP operator. This allows us to unify the scaling code for general (periodic and non-periodic) SBP operators and should be used in #1014. The final goal should be to unify the interface there:

  • It doesn't matter which domain you chose when constructing the SBP operator
  • All SBP operators will be mapped to [-1, 1] internally
  • The real domain is specified when constructing the mesh in Trixi.jl

@ranocha ranocha requested a review from jlchan December 13, 2021 09:26
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1015 (e906e84) into main (c90edae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         291      291           
  Lines       22420    22421    +1     
=======================================
+ Hits        21088    21089    +1     
  Misses       1332     1332           
Flag Coverage Δ
unittests 94.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/dgmulti/sbp.jl 95.81% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90edae...e906e84. Read the comment docs.

Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jlchan jlchan merged commit 2e221fc into main Dec 13, 2021
@jlchan jlchan deleted the hr/xmin_xmax branch December 13, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants