Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "restrict ArrayInterface to working version" #1171

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jun 10, 2022

Reverts #1170. Tests should hopefully pass with ArrayInterface.jl v6.0.15. See JuliaArrays/ArrayInterface.jl#304 and JuliaArrays/ArrayInterface.jl#307

Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping tabs on upstream fixes! Fingers crossed CI passes now.

@ranocha ranocha marked this pull request as ready for review June 10, 2022 17:12
@ranocha ranocha enabled auto-merge (squash) June 10, 2022 17:12
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1171 (d29a610) into main (fd00d42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         310      310           
  Lines       24282    24282           
=======================================
  Hits        23503    23503           
  Misses        779      779           
Flag Coverage Δ
unittests 96.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd00d42...d29a610. Read the comment docs.

@ranocha ranocha merged commit 04f5f78 into main Jun 10, 2022
@ranocha ranocha deleted the revert-1170-ranocha-patch-2 branch June 10, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants