Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant definition of cons2prim #1253

Merged
merged 1 commit into from
Nov 7, 2022
Merged

remove redundant definition of cons2prim #1253

merged 1 commit into from
Nov 7, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 7, 2022

cons2prim is already defined in

"""
cons2prim(u, equations)
Convert the conserved variables `u` to the primitive variables for a given set of
`equations`. `u` is a vector type of the correct length `nvariables(equations)`.
Notice the function doesn't include any error checks for the purpose of efficiency,
so please make sure your input is correct.
The inverse conversion is performed by [`prim2cons`](@ref).
"""
function cons2prim end

@ranocha ranocha requested a review from sloede November 7, 2022 10:44
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloede sloede enabled auto-merge (squash) November 7, 2022 11:24
@sloede sloede merged commit 85533d9 into main Nov 7, 2022
@sloede sloede deleted the ranocha-patch-1 branch November 7, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants