Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to SimpleUnPack.jl #1376

Merged
merged 4 commits into from
Mar 17, 2023
Merged

switch to SimpleUnPack.jl #1376

merged 4 commits into from
Mar 17, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 16, 2023

Just use SimpleUnPack.jl - simplified version of #1367

@ranocha ranocha requested a review from sloede March 16, 2023 14:31
@ranocha ranocha changed the title switch tp SimpleUnPack.jl switch to SimpleUnPack.jl Mar 16, 2023
sloede
sloede previously approved these changes Mar 16, 2023
@ranocha ranocha enabled auto-merge (squash) March 16, 2023 14:32
@ranocha
Copy link
Member Author

ranocha commented Mar 17, 2023

The test elixir_advection_shockcapturing.jl failed. I think this was caused by floating point differences and maybe CFL magic. While fixing the test, I realized it was using polydeg = 4 while we usually choose polydeg = 3 to reduce compilation times. I fixed that as well.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1376 (a776f61) into main (a0fa4ae) will increase coverage by 25.76%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1376       +/-   ##
===========================================
+ Coverage   70.20%   95.96%   +25.76%     
===========================================
  Files         344      344               
  Lines       28434    28499       +65     
===========================================
+ Hits        19960    27347     +7387     
+ Misses       8474     1152     -7322     
Flag Coverage Δ
unittests 95.96% <100.00%> (+25.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ctured_1d_dgsem/elixir_advection_shockcapturing.jl 94.74% <ø> (ø)
src/Trixi.jl 71.43% <ø> (ø)
src/solvers/dgsem_tree/indicators_1d.jl 91.36% <100.00%> (+64.55%) ⬆️

... and 116 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ranocha ranocha requested a review from sloede March 17, 2023 10:33
@ranocha
Copy link
Member Author

ranocha commented Mar 17, 2023

Windows MPI fails again...

@ranocha ranocha disabled auto-merge March 17, 2023 10:37
@ranocha ranocha merged commit f7a21bf into main Mar 17, 2023
@ranocha ranocha deleted the hr/SimpleUnPack branch March 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants