Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for allocations from mortars #1405

Merged
merged 2 commits into from
Apr 20, 2023
Merged

check for allocations from mortars #1405

merged 2 commits into from
Apr 20, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Apr 20, 2023

No description provided.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I have a small suggestion regarding the wording of the comment, but other than that it LGTM.

test/test_p4est_2d.jl Outdated Show resolved Hide resolved
@ranocha ranocha requested a review from sloede April 20, 2023 08:36
@sloede sloede enabled auto-merge (squash) April 20, 2023 08:37
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1405 (5825d7b) into main (5e28148) will increase coverage by 6.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   89.90%   95.97%   +6.07%     
==========================================
  Files         351      351              
  Lines       29108    29117       +9     
==========================================
+ Hits        26169    27945    +1776     
+ Misses       2939     1172    -1767     
Flag Coverage Δ
unittests 95.97% <ø> (+6.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ranocha ranocha disabled auto-merge April 20, 2023 12:00
@ranocha ranocha merged commit 82932dd into main Apr 20, 2023
25 of 26 checks passed
@ranocha ranocha deleted the hr/check_mortars branch April 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants