-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPI: Handle sanity checks during initialization of unstructured boundary conditions differently #1447
Conversation
I cannot see the reasons for checks crashing. Github seem to not work correctly now. |
Yes, GitHub has some problems today... |
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 95.72% 95.71% -0.00%
==========================================
Files 358 358
Lines 29643 29657 +14
==========================================
+ Hits 28374 28386 +12
- Misses 1269 1271 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…into Issue1047
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this! I have left a few comments and suggestions
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please also request a review from @lchristm. If he approves as well, this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Fix #1047: