Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI: Handle sanity checks during initialization of unstructured boundary conditions differently #1447

Merged
merged 22 commits into from
May 15, 2023

Conversation

ArseniyKholod
Copy link
Contributor

@ArseniyKholod ArseniyKholod commented May 10, 2023

Fix #1047:

During initialization of the boundary conditions for unstructured meshes (UnstructuredMesh and P4estMesh), there is a check if the boundary names given by the user via a dictionary are valid. This check compares the names given by the user in the dictionary to the names found in the boundary container. While this works fine for serial runs, this check can't be done in parallel runs because the local domain might not contain all boundaries and thus not all valid boundary names are present in the boundary container. In that case the check would fail even if all boundary names given by the user are valid.

@ArseniyKholod
Copy link
Contributor Author

I cannot see the reasons for checks crashing. Github seem to not work correctly now.

@ranocha
Copy link
Member

ranocha commented May 10, 2023

Yes, GitHub has some problems today...

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1447 (ac9ae41) into main (f581b9d) will decrease coverage by 0.00%.
The diff coverage is 86.67%.

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
- Coverage   95.72%   95.71%   -0.00%     
==========================================
  Files         358      358              
  Lines       29643    29657      +14     
==========================================
+ Hits        28374    28386      +12     
- Misses       1269     1271       +2     
Flag Coverage Δ
unittests 95.71% <86.67%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ers/dgsem_unstructured/sort_boundary_conditions.jl 91.11% <86.67%> (-2.44%) ⬇️

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this! I have left a few comments and suggestions

ArseniyKholod and others added 9 commits May 13, 2023 10:46
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@ArseniyKholod ArseniyKholod requested a review from sloede May 13, 2023 09:31
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please also request a review from @lchristm. If he approves as well, this can be merged.

Copy link
Member

@lchristm lchristm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ranocha ranocha enabled auto-merge (squash) May 15, 2023 05:22
@ranocha ranocha disabled auto-merge May 15, 2023 05:23
@ranocha ranocha enabled auto-merge (squash) May 15, 2023 05:23
@ranocha ranocha disabled auto-merge May 15, 2023 07:17
@ranocha ranocha merged commit 3096a38 into trixi-framework:main May 15, 2023
25 of 28 checks passed
@ArseniyKholod ArseniyKholod deleted the Issue1047 branch July 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI: Handle sanity checks during initialization of unstructured boundary conditions differently
4 participants