Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dgmulti test (roundoff level changes) #1449

Merged
merged 1 commit into from
May 12, 2023

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 11, 2023

Should fix the failing unstructured_dgmulti tests in #1316

@jlchan jlchan requested a review from ranocha May 11, 2023 17:48
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1449 (bf9462a) into hr/ci_julia19 (cd5c0ab) will decrease coverage by 1.75%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           hr/ci_julia19    #1449      +/-   ##
=================================================
- Coverage          92.61%   90.86%   -1.75%     
=================================================
  Files                357      357              
  Lines              29558    29576      +18     
=================================================
- Hits               27375    26874     -501     
- Misses              2183     2702     +519     
Flag Coverage Δ
unittests 90.86% <ø> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. MPI CI on Linux fails again - I'll merge this nevertheless since it is not rlated to this PR and also fails on main etc.

@ranocha ranocha merged commit 81a9464 into trixi-framework:hr/ci_julia19 May 12, 2023
26 of 28 checks passed
ranocha added a commit that referenced this pull request May 30, 2023
* check CI on Julia 1.9

* use the v1.9 stable release

* update dgmulti test (roundoff level changes) (#1449)

* use --heap-size-hint=1G for MPI runs in CI

* adjust tolerance for one DGMulti test

* Revert "move Linux MPI to separate CI job (#1497)"

This reverts commit da457e4.

* update to Julia v1.9

* use package extension on Julia v1.9.0

* Apply suggestions from code review

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

---------

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants