Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile less when running tests #1455

Merged
merged 2 commits into from
May 12, 2023
Merged

precompile less when running tests #1455

merged 2 commits into from
May 12, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented May 12, 2023

This sets preferences to precompile less stuff in OrdinaryDiffEq.jl when running our tests. This hopefully should reduce the total CI time for us.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable (if it works - is it recognized by OrdinaryDiffEq?)

@ranocha
Copy link
Member Author

ranocha commented May 12, 2023

Here are some timings of precompilation (without coverage) from earlier CI runs

System Precompile time Link
CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 897 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401715#step:7:891
CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 825 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401965#step:7:891
CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz 840 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401383#step:7:891
CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 923 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854402231#step:7:891
CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 797 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401614#step:7:891
CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 756 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401824#step:7:891
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 709 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854401499#step:7:891
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 729 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4950586929/jobs/8854402487#step:7:891

And here are some results from this PR

System Precompile time Link
CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 762 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4958533178/jobs/8871521584#step:7:889
CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 749 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4958533178/jobs/8871522223#step:7:889
CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 705 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4958533178/jobs/8871522325#step:7:889
CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 645 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4958533178/jobs/8871521438#step:7:889
CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 596 seconds https://github.com/trixi-framework/Trixi.jl/actions/runs/4958533178/jobs/8871521836#step:7:889

Both are from Linux Ci runners. It looks like a net win here?

@ranocha ranocha marked this pull request as ready for review May 12, 2023 12:53
@ranocha ranocha enabled auto-merge (squash) May 12, 2023 12:53
@ranocha ranocha closed this May 12, 2023
auto-merge was automatically disabled May 12, 2023 12:56

Pull request was closed

@ranocha ranocha reopened this May 12, 2023
@ranocha ranocha enabled auto-merge (squash) May 12, 2023 12:56
@ranocha ranocha merged commit 6df64e9 into main May 12, 2023
30 of 55 checks passed
@ranocha ranocha deleted the hr/precompile_less branch May 12, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants