Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparation for DGMulti shock capturing #1458

Merged
merged 15 commits into from
May 16, 2023

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 12, 2023

I'm currently adding shock capturing to DGMulti. This is a minor PR adding some interfaces and minor refactoring (to reduce the size of the full PR).

@jlchan jlchan requested review from ranocha and sloede May 12, 2023 20:25
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1458 (4ee3e18) into main (f581b9d) will decrease coverage by 0.01%.
The diff coverage is 92.31%.

❗ Current head 4ee3e18 differs from pull request most recent head a326dcc. Consider uploading reports for the commit a326dcc to get more accurate results

@@            Coverage Diff             @@
##             main    #1458      +/-   ##
==========================================
- Coverage   95.72%   95.71%   -0.01%     
==========================================
  Files         358      358              
  Lines       29643    29641       -2     
==========================================
- Hits        28374    28370       -4     
- Misses       1269     1271       +2     
Flag Coverage Δ
unittests 95.71% <92.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Trixi.jl 68.18% <ø> (ø)
src/solvers/dgmulti/types.jl 96.64% <0.00%> (-1.31%) ⬇️
src/callbacks_step/analysis_dgmulti.jl 80.00% <100.00%> (ø)
src/solvers/dgmulti/flux_differencing.jl 87.68% <100.00%> (-0.09%) ⬇️
src/solvers/dgmulti/flux_differencing_gauss_sbp.jl 93.16% <100.00%> (-0.05%) ⬇️

@jlchan jlchan changed the title adding some interfaces for DGMulti shock capturing preparation for DGMulti shock capturing May 13, 2023
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great plan!

src/solvers/dgmulti/flux_differencing.jl Show resolved Hide resolved
src/solvers/dgmulti/flux_differencing.jl Show resolved Hide resolved
src/solvers/dgmulti/flux_differencing.jl Show resolved Hide resolved
src/solvers/dgmulti/flux_differencing.jl Show resolved Hide resolved
src/solvers/dgmulti/types.jl Outdated Show resolved Hide resolved
src/solvers/dgmulti/types.jl Show resolved Hide resolved
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to be merged from my side if tests pass (maybe ignoring the Linux MPI CI error we don't understand...)

@ranocha ranocha merged commit 6e5ea13 into trixi-framework:main May 16, 2023
24 of 26 checks passed
@jlchan jlchan deleted the jc/prep_for_DGMulti_SC branch May 16, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants