-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparation for DGMulti
shock capturing
#1458
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
- Coverage 95.72% 95.71% -0.01%
==========================================
Files 358 358
Lines 29643 29641 -2
==========================================
- Hits 28374 28370 -4
- Misses 1269 1271 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DGMulti
shock capturingDGMulti
shock capturing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a great plan!
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
This reverts commit 7e0c458.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to be merged from my side if tests pass (maybe ignoring the Linux MPI CI error we don't understand...)
I'm currently adding shock capturing to
DGMulti
. This is a minor PR adding some interfaces and minor refactoring (to reduce the size of the full PR).