-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First order finite volume 1D #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@sloede It would be nice to get a brief review from you since I was involved in this PR.
This enables the functionality requested in #1318 on the 1D |
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
- Coverage 95.70% 95.66% -0.04%
==========================================
Files 360 360
Lines 29816 29835 +19
==========================================
+ Hits 28533 28539 +6
- Misses 1283 1296 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, I have only two small suggestions/questions
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution and for bearing with us in the review process. LGTM 👍
I enabled first order finite volume methods on the 1D TreeMesh. Therefore I modified Lobatto Legendre basis to allow polynomial degree zero and fixed the determination of cell midpoints. Last I modified the visualization to receive the right cell boundaries and added a test.
Here is the result of a convergence test
Here is a plot result