Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review checklist to new PRs #1609

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Add review checklist to new PRs #1609

merged 3 commits into from
Aug 22, 2023

Conversation

sloede
Copy link
Member

@sloede sloede commented Aug 17, 2023

As discussed on Slack and in #1607.

Resolves #1529, closes #1607.

Needs trixi-framework/add-pr-review-checklist#2 to be merged first and v1 to be tagged there. EDIT: done

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1609 (d9517bf) into main (add3a7f) will decrease coverage by 7.61%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   91.12%   83.51%   -7.61%     
==========================================
  Files         414      414              
  Lines       33929    33922       -7     
==========================================
- Hits        30917    28329    -2588     
- Misses       3012     5593    +2581     
Flag Coverage Δ
unittests 83.51% <ø> (-7.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 117 files with indirect coverage changes

@sloede sloede marked this pull request as ready for review August 22, 2023 17:19
@sloede sloede enabled auto-merge (squash) August 22, 2023 17:20
Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sloede sloede disabled auto-merge August 22, 2023 17:30
@sloede sloede merged commit e22b11e into main Aug 22, 2023
28 checks passed
@sloede sloede deleted the msl/add-review-checklist branch August 22, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review checklist for PRs Write guidelines and checklist for code reviews
3 participants