Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase absolute tolerance to make CI pass with julia v1.9.3 #1625

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

JoshuaLampert
Copy link
Member

With julia v1.9.3 one test fails due to different l2 and linf errors, which is quite annoying. This PR simply increases the absolute tolerance as suggested by @ranocha in #1617 (comment). We need an absolute tolerance of 3e-10, which IMHO is quite high... I've also noticed a mismatch in the docstring of @test_trixi_include.
Fixes #1617.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This change is fine with me.

If we have some time, it would be interesting to see whether the same kind of difference between Julia v1.9.0 and v1.9.3 persists if we choose controller = PIDController(0.55, -0.27, 0.05) as keyword argument in solve (this is a good controller for SSPRK43, see #1087).

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +39.03% 🎉

Comparison is base (f098ea2) 49.33% compared to head (6a4f2c3) 88.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1625       +/-   ##
===========================================
+ Coverage   49.33%   88.36%   +39.03%     
===========================================
  Files         414      414               
  Lines       33839    33888       +49     
===========================================
+ Hits        16692    29943    +13251     
+ Misses      17147     3945    -13202     
Flag Coverage Δ
unittests 88.36% <ø> (+39.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 248 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha enabled auto-merge (squash) September 6, 2023 13:34
@ranocha ranocha merged commit 4e6d163 into trixi-framework:main Sep 6, 2023
30 checks passed
@JoshuaLampert JoshuaLampert deleted the reference-vals branch September 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different test values on julia v1.9.3
2 participants