-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase absolute tolerance to make CI pass with julia v1.9.3 #1625
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This change is fine with me.
If we have some time, it would be interesting to see whether the same kind of difference between Julia v1.9.0 and v1.9.3 persists if we choose controller = PIDController(0.55, -0.27, 0.05)
as keyword argument in solve
(this is a good controller for SSPRK43
, see #1087).
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
===========================================
+ Coverage 49.33% 88.36% +39.03%
===========================================
Files 414 414
Lines 33839 33888 +49
===========================================
+ Hits 16692 29943 +13251
+ Misses 17147 3945 -13202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
With julia v1.9.3 one test fails due to different
l2
andlinf
errors, which is quite annoying. This PR simply increases the absolute tolerance as suggested by @ranocha in #1617 (comment). We need an absolute tolerance of3e-10
, which IMHO is quite high... I've also noticed a mismatch in the docstring of@test_trixi_include
.Fixes #1617.