-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PERK2 time integration method to use fixed time step #1958
base: main
Are you sure you want to change the base?
Refactor PERK2 time integration method to use fixed time step #1958
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
- Coverage 96.11% 96.11% -0.00%
==========================================
Files 460 460
Lines 36926 36947 +21
==========================================
+ Hits 35490 35509 +19
- Misses 1436 1438 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…Trixi.jl into PERK_p2_Single_fixed_time_step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
As mentioned by @ranocha in #1908 , a user is now able to set a fixed time step for simulations without a stepsize callback for PERK2 time integration method. The implementation is from @bennibolm in #1919.