Add numerical support of other real types (navier)

[huiyuxie]

Continue #1909.

Tasks:

• compressible_navier_stokes 1d, 2d, 3d
• unit tests for above

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (e114d01) to head (948914e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1968   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         460      460           
  Lines       36980    36980           
=======================================
  Hits        35560    35560           
  Misses       1420     1420           

Flag	Coverage Δ
unittests	96.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ranocha]

LGTM, thanks. Could you please add some unit tests?

[huiyuxie]

I'm waiting for the previous one getting merged. There would possibly be conflicts in the unit test file and I don't like resolving code conflicts ;)

[ranocha]

Thanks! This looks good so far. The next step is to add unit tests

[ranocha]

Thanks a lot! This looks already quite good to me.

[huiyuxie]

Ready for final review and merge @ranocha :/

[ranocha]

Thanks

[ranocha]

Could you please resolve the conflicts so that we can merge this PR?

[huiyuxie]

@ranocha Sure but I'm curious that you are unable to resolve this issue on your end?

[huiyuxie]

That's why I request you to review and merge them timely - if not, my later PRs would easily get conflicts with the former PR.

[ranocha]

I would be able to resolve the conflicts. But I would need to allocate more time for that. If you want to get this PR merged quickly, it will be faster if you resolve the conflicts.

[huiyuxie]

Ok please merge ^^

[huiyuxie]

@ranocha ^^

[ranocha]

Thanks!