Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numerical support of other real types (hyperbolic) #1969

Merged
merged 10 commits into from
Jun 23, 2024

Conversation

huiyuxie
Copy link
Member

@huiyuxie huiyuxie commented Jun 7, 2024

Continue #1909.

Tasks:

  • hyperbolic_diffusion 1d, 2d, 3d
  • unit tests for above

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@huiyuxie huiyuxie self-assigned this Jun 7, 2024
@huiyuxie huiyuxie added the enhancement New feature or request label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (57d1730) to head (911c609).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         460      460           
  Lines       36968    36980   +12     
=======================================
+ Hits        35548    35560   +12     
  Misses       1420     1420           
Flag Coverage Δ
unittests 96.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huiyuxie
Copy link
Member Author

huiyuxie commented Jun 17, 2024

function HyperbolicDiffusionEquations1D(; nu = 1.0, Lr = inv(2pi))
Tr = Lr^2 / nu
HyperbolicDiffusionEquations1D(promote(Lr, inv(Tr), nu)...)
end

Should we agree on that it is okay to let the default mode be Float64 when no argument is passed? @ranocha

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please find some comments below.

src/equations/hyperbolic_diffusion_2d.jl Outdated Show resolved Hide resolved
src/equations/hyperbolic_diffusion_3d.jl Outdated Show resolved Hide resolved
@ranocha
Copy link
Member

ranocha commented Jun 18, 2024

function HyperbolicDiffusionEquations1D(; nu = 1.0, Lr = inv(2pi))
Tr = Lr^2 / nu
HyperbolicDiffusionEquations1D(promote(Lr, inv(Tr), nu)...)
end

Should we agree on that it is okay to let the default mode be Float64 when no argument is passed? @ranocha

Yes, that's fine 👍

@huiyuxie
Copy link
Member Author

Ready for final review and merge @ranocha ^^

@huiyuxie huiyuxie requested a review from ranocha June 21, 2024 07:35
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha enabled auto-merge (squash) June 23, 2024 15:50
@ranocha ranocha merged commit e114d01 into trixi-framework:main Jun 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants