Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CI on Julia v1.7 #985

Merged
merged 13 commits into from
Feb 9, 2022
Merged

Check CI on Julia v1.7 #985

merged 13 commits into from
Feb 9, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 19, 2021

We get the following problems:

  • tree_part1:
    ┌ Warning: Package Trixi does not have Flux in its dependencies:
    │ - If you have Trixi checked out for development and have
    │   added Flux as a dependency but haven't updated your primary
    │   environment's manifest file, try `Pkg.resolve()`.
    │ - Otherwise you may need to report an issue with Trixi
    └ Loading Flux into Trixi from project dependency, future warnings for Trixi are suppressed.
    
  • tree_part2: Some test failures of elixir_euler_kelvin_helmholtz_instability_amr_neuralnetwork_perssonperaire.jl
  • structured:
    elixir_advection_restart.jl with waving flag mesh: Test Failed at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:77
      Expression: isapprox(linf_expected, linf_actual, atol = 1.1102230246251565e-13, rtol = 5.0e-7)
       Evaluated: isapprox(0.0015194298895079283, 0.0015194252169410394; atol = 1.1102230246251565e-13, rtol = 5.0e-7)
    
  • misc_part1:
    plotting TimeIntegratorSolution: Test Failed at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:129
      Expression: isempty(stderr_content)
       Evaluated: isempty("┌ Warning: Interrupted. Larger maxiters is needed.\n└ @ Trixi ~/work/Trixi.jl/Trixi.jl/src/time_integration/methods_3Sstar.jl:215\n")
    
  • misc_part1:
    plotting multiple variables: Test Failed at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:129
      Expression: isempty(stderr_content)
       Evaluated: isempty("┌ Warning: Keyword argument letter not supported with Plots.GRBackend().  Choose from: Set([:top_margin, :group, :inset_subplots, :background_color, :ytickfontsize, :yforeground_color_text, :yguidefontcolor, :tickfontfamily, :show_empty_bins, :seriesalpha, :seriescolor, :ztick_direction, :xgrid, :ygridalpha, :zlims, :xtick_direction, :colorbar, :legend_font_family, :zflip, :ticks, :linealpha, :overwrite_figure, :arrow, :xguidefonthalign, :normalize, :linestyle, :xtickfontvalign, :xflip, :zgrid, :fillcolor, :ygrid, :bar_width, :colorbar_scale, :background_color_inside, :zguidefonthalign, :bins, :zguide, :zforeground_color_text, :legend_font_valign, :yscale, :legend_font_color, :weights, :xgridalpha, :ygridstyle, :clims, :xtickfontcolor, :fill_z, :xguide, :markershape, :background_color_subplot, :ztickfontfamily, :fillalpha, :markerstrokewidth, :tick_direction, :xguidefontvalign, :xguidefontfamily, :gridlinewidth, :foreground_color_subplot, :xgridlinewidth, :yguidefontsize, :foreground_color, :foreground_color_text, :titlefonthalign, :yerror, :x, :xtickfonthalign, :zgridlinewidth, :ytickfontrotation, :discrete_values, :ytick_direction, :grid, :xguidefontrotation, :ribbon, :xguidefontsize, :tickfontrotation, :xforeground_color_axis, :xdiscrete_values, :background_color_outside, :titlefontcolor, :xgridstyle, :line_z, :size, :orientation, :gridstyle, :projection, :markersize, :legend_foreground_color, :camera, :zguidefontrotation, :ydiscrete_values, :xforeground_color_grid, :seriestype, :yflip, :quiver, :zticks, :markerstrokecolor, :ztickfontrotation, :ztickfonthalign, :fillrange, :ztickfontvalign, :xlims, :xforeground_color_border, :markercolor, :xtickfontsize, :ylink, :levels, :color_palette, :connections, :yforeground_color_grid, :lims, :zgridstyle, :foreground_color_border, :zguidefontvalign, :xscale, :marker_z, :markerstrokealpha, :left_margin, :markeralpha, :legend_font_halign, :annotations, :window_title, :tickfontvalign, :foreground_color_axis, :zguidefontcolor, :ygridlinewidth, :zlink, :zscale, :smooth, :yguidefontrotation, :xticks, :guidefontsize, :zguidefontsize, :y, :margin, :ytickfontcolor, :zdiscrete_values, :tickfonthalign, :bottom_margin, :yforeground_color_border, :zguidefontfamily, :framestyle, :yguidefontvalign, :yguidefonthalign, :zerror, :zgridalpha, :ztickfontcolor, :scale, :legend_position, :linecolor, :html_output_format, :legend_title, :zforeground_color_border, :legend_font_pointsize, :title, :tickfontcolor, :subplot_index, :flip, :titlefontrotation, :legend_background_color, :tickfontsize, :titlefontvalign, :z, :yforeground_color_axis, :foreground_color_grid, :xtickfontrotation, :linewidth, :ztickfontsize, :gridalpha, :xerror, :guidefontfamily, :ylims, :contour_labels, :xguidefontcolor, :primary, :xtickfontfamily, :ytickfontvalign, :guidefonthalign, :ytickfontfamily, :aspect_ratio, :xforeground_color_text, :show, :link, :colorbar_title, :guidefontrotation, :subplot, :label, :ytickfonthalign, :guide, :guidefontcolor, :yguide, :titlefontsize, :titlefontfamily, :guidefontvalign, :zforeground_color_axis, :zforeground_color_grid, :layout, :legend_font_rotation, :colorbar_entry, :yguidefontfamily, :polar, :right_margin, :xlink, :series_annotations, :yticks])\n└ @ Plots ~/.julia/packages/Plots/PomtQ/src/args.jl:1608\n")
    

@ranocha
Copy link
Member Author

ranocha commented Dec 1, 2021

@sloede Since you have supervised the neural network stuff, could you please check and fix the test failures of elixir_euler_kelvin_helmholtz_instability_amr_neuralnetwork_perssonperaire.jl?

@ranocha ranocha requested a review from sloede February 9, 2022 04:56
@ranocha ranocha marked this pull request as ready for review February 9, 2022 04:56
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions/comments, but overall LGTM.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
docs/src/development.md Show resolved Hide resolved
test/test_trixi.jl Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #985 (8f2acd2) into main (4814ed1) will increase coverage by 2.99%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   93.59%   96.59%   +2.99%     
==========================================
  Files         298      298              
  Lines       23054    23054              
==========================================
+ Hits        21577    22267     +690     
+ Misses       1477      787     -690     
Flag Coverage Δ
unittests 96.59% <0.00%> (+2.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Trixi.jl 66.67% <0.00%> (ø)
src/solvers/dgsem/basis_lobatto_legendre.jl 88.89% <0.00%> (+0.34%) ⬆️
src/visualization/types.jl 94.82% <0.00%> (+0.52%) ⬆️
src/solvers/dgsem_tree/dg_2d_parallel.jl 100.00% <0.00%> (+0.58%) ⬆️
src/visualization/utilities.jl 89.89% <0.00%> (+0.60%) ⬆️
src/meshes/p4est_mesh.jl 99.05% <0.00%> (+0.68%) ⬆️
src/callbacks_step/amr_dg3d.jl 99.19% <0.00%> (+0.81%) ⬆️
src/callbacks_step/amr_dg1d.jl 96.72% <0.00%> (+0.82%) ⬆️
src/meshes/unstructured_mesh.jl 99.12% <0.00%> (+0.88%) ⬆️
src/meshes/parallel_tree.jl 100.00% <0.00%> (+0.96%) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397cf7e...8f2acd2. Read the comment docs.

@ranocha ranocha merged commit 8c8b43c into main Feb 9, 2022
@ranocha ranocha deleted the hr/CI_Julia17 branch February 9, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants