-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check CI on Julia v1.7 #985
Conversation
cc106c7
to
cf2a654
Compare
@sloede Since you have supervised the neural network stuff, could you please check and fix the test failures of |
…euralnetwork_perssonperaire.jl anymore The new errors differ by ca. 10% from the old ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions/comments, but overall LGTM.
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 93.59% 96.59% +2.99%
==========================================
Files 298 298
Lines 23054 23054
==========================================
+ Hits 21577 22267 +690
+ Misses 1477 787 -690
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We get the following problems:
tree_part1
:tree_part2
: Some test failures ofelixir_euler_kelvin_helmholtz_instability_amr_neuralnetwork_perssonperaire.jl
structured
:misc_part1
:misc_part1
: