Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Trixi to 0.4 for package test, (keep existing compat) #46

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Trixi package from 0.3 to 0.3, 0.4 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2021-10-19-00-13-54-138-00867131311 branch from 00b1b54 to 8c57a1b Compare October 19, 2021 00:14
@ranocha
Copy link
Member

ranocha commented Oct 19, 2021

@sloede We got different hashes again...

@ranocha
Copy link
Member

ranocha commented Oct 19, 2021

Moreover, examples/p4est_2d_dgsem/elixir_euler_source_terms_nonperiodic.jl was removed in trixi-framework/Trixi.jl#892.

@sloede
Copy link
Member

sloede commented Oct 19, 2021

We really need to write tests based on ReadVTK.jl...

@ranocha
Copy link
Member

ranocha commented Oct 19, 2021

Yeah... I added Trixi2Vtk to the agenda of our next meeting. Let's see whether we can motivate someone to invest some time

@sloede sloede closed this in #48 Oct 22, 2021
@ranocha ranocha deleted the compathelper/new_version/2021-10-19-00-13-54-138-00867131311 branch October 24, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants