Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.jl as dependency for PackageCompiler #145

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Oct 27, 2023

If options are changed, make should re-trigger PackageCompiler

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a47d01e) 97.98% compared to head (4d05bd2) 97.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          13       13           
  Lines         546      546           
=======================================
  Hits          535      535           
  Misses         11       11           
Flag Coverage Δ
unittests 97.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sloede sloede merged commit fb17806 into main Oct 30, 2023
10 checks passed
@sloede sloede deleted the add-build-jl-dependency branch October 30, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants