Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in ~/.icons folder do not show up #15

Closed
erikdubois opened this issue Jul 17, 2017 · 9 comments
Closed

Icons in ~/.icons folder do not show up #15

erikdubois opened this issue Jul 17, 2017 · 9 comments

Comments

@erikdubois
Copy link

erikdubois commented Jul 17, 2017

I have been at it for hours to understand an issue we have with the icons.
Not sure but I do believe this is an actual bug or more an improvement.

In ~/.icons I have dumped 104 icon themes with a total of 169942 icons. Just telling you this because maybe the sheer number may matter in your script.

These icons depend on the core icon themes in /usr/share/icons.
In the index.theme you will find this line (or similar)
Inherits=Sardi-Orb-Colora,Sardi,Numix-Circle,Numix,Papirus,Moka,Surfn,breeze,gnome,hicolor

If you select an icon theme from ~/.icons folder then it will look for Sardi-Orb-Colora,Sardi etc... BUT it will not find those in ~/.icons so it stops and the menu is broken. It should keep looking in /usr/share/icons for the missing themes. My guess the solution is in there to fix the solution with the broken icons.

Solution now

  1. put all icons in ~/.icons
  2. put all icons in /usr/share/icons

Tried to work with setting in config.pl as well (also with slash behind it)
icon_dirs_first => "$ENV{HOME}/.icons",

archlabs_2017-07-17-53_3840x1080
archlabs_2017-07-17-19_3840x1080

@trizen
Copy link
Owner

trizen commented Jul 18, 2017

Thank you for taking the time in reporting this issue.

I decided to use the Gtk2 Perl module for resolving the absolute paths to icons, which should be a very robust solution, compared to the sketchy code in Linux::DesktopFiles.

Please try the latest commit and, if everything is OK, you may close this issue. Thanks again for the report.

@erikdubois
Copy link
Author

Hi,
wanted to test it out and went to the AUR
There is no obmenu-generator-git there yet.
I saw you are maintaining the 0.71 version.
Could you consider making a git version?
Will test it now.

@erikdubois
Copy link
Author

erikdubois commented Jul 21, 2017

Error when asking to make icons piped or static
Obmenu-generator 0.71 is in place.
I replace /usr/bin/obmenu-generator with the one from github. I kept my own schema.pl and config.pl. Menu without icons still works.
obmenu

making a static menu with icons just clears the menu.xml totally - no more menu's - blanco file

@trizen
Copy link
Owner

trizen commented Jul 21, 2017

Thanks for testing the latest git version.

Make sure that Gtk2 module is installed (gtk2-perl). Additionally, to see what is really going on, please execute obmenu-generator -i -d in a terminal and post here the error messages, if any.

I will consider uploading a "-git" version of obmenu-generator to AUR, and also tagging a new version (once we are sure it's working correctly), but this may not happen very soon, unfortunately.

@erikdubois
Copy link
Author

erikdubois commented Jul 22, 2017

seems to work with gtk2-perl
make an aur package and I will ask the ArchLabs team to test a bit further
no error messages

@trizen
Copy link
Owner

trizen commented Aug 23, 2017

Finally, a new version is here (https://github.com/trizen/obmenu-generator/releases/tag/0.80), which should fix this issue. If everything is OK, we can close this.

@erikdubois
Copy link
Author

Hi trizen,
I am on the point of creating my own spinoff of ArchLabs named https://archmerge.com.
Very happy what you did with the code - svg's are incredibly fast - piped with icons
0-80-1

@trizen
Copy link
Owner

trizen commented Sep 15, 2017

Hi Erik,
I'm very happy to hear that. I wish you all the best on your new project. 👍

@trizen trizen closed this as completed Sep 15, 2017
@JuPlutonic
Copy link

Ok, gtk2 is a new dependency.
With old dependency Linux::DesktopFiles it always have issue Can't locate object method "get_icon_path" via package "Linux::DesktopFiles" at /opt/bin/obmenu-generator line 446.
Now when I installed gtk2-perl with cpan Gtk2 command the o-g working smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants