Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /usr/local/share/icons to the list of icon directories #6

Closed
wants to merge 1 commit into from
Closed

Add /usr/local/share/icons to the list of icon directories #6

wants to merge 1 commit into from

Conversation

elboulangero
Copy link
Contributor

Hi,
same thing as #5, for icons this time. Sorry that I didn't think about it before.

@trizen
Copy link
Owner

trizen commented Aug 6, 2015

Sorry. This is not something that I can accept, as it decreases the performance of the script with no real benefits for all users.

Considering that a user might have two or more icon themes installed under /usr/local/share/icons, traversing the entire path not only slows down the script, but also populates the icon.db cache with useless entries, increasing its loading time.

I would say to leave this as something a user will add to he's config.pl file when it's really necessary. ;)

@trizen trizen closed this Aug 6, 2015
@elboulangero
Copy link
Contributor Author

Ok, no worries, I didn't think so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants